[w3m-dev-en 00110] Re: w3m-0.1.8

From: w3m-dev-en@mips.rhein-neckar.de
Date: Thu Apr 06 2000 - 18:44:42 CDT

<aito@ei5sun.yz.yamagata-u.ac.jp> wrote:

> The looooooooooooooooooooong waited new version 0.1.8
> is just released.

I'd like to raise a coding style issue. So far, w3m has been written
in pure C, not C++. Thus I would prefer if comments kept following
C syntax, i.e. "/* ... */", rather than C++ "// ...".

--- linein.c.old Thu Apr 6 22:11:29 2000
+++ linein.c Thu Apr 6 22:12:35 2000
@@ -120,17 +120,17 @@
 #ifdef __EMX__
     if(!c)
       switch(getch()){
- case 83: c=ctrl('d'); break; // del
- case 75: c=ctrl('b'); break; // left arrow
- case 77: c=ctrl('f'); break; // right arrow
- case 72: c=ctrl('p'); break; // up arrow
- case 81: c=ctrl('n'); break; // down arrow
- case 71: // home
- case 115: c=ctrl('a'); break; // ctrl + left arrow
- case 79: // end
- case 116: c=ctrl('e'); break; // ctrl + right arrow
- case 119: c=ctrl('u'); break; // ctrl + home
- case 117: c=ctrl('k'); // ctrl + end
+ case 83: c=ctrl('d'); break; /* del */
+ case 75: c=ctrl('b'); break; /* left arrow */
+ case 77: c=ctrl('f'); break; /* right arrow */
+ case 72: c=ctrl('p'); break; /* up arrow */
+ case 81: c=ctrl('n'); break; /* down arrow */
+ case 71: /* home */
+ case 115: c=ctrl('a'); break; /* ctrl + left arrow */
+ case 79: /* end */
+ case 116: c=ctrl('e'); break; /* ctrl + right arrow */
+ case 119: c=ctrl('u'); break; /* ctrl + home */
+ case 117: c=ctrl('k'); /* ctrl + end */
       }
 #endif
     redrawOK = T;
--- local.c.old Thu Apr 6 22:14:32 2000
+++ local.c Thu Apr 6 22:14:52 2000
@@ -149,8 +149,8 @@
   if (status != CGIFN_CGIBIN ) {
     char tmp[_MAX_PATH];
 
- _abspath(tmp,lib_dir,_MAX_PATH); // Translate '\\' to '/'
- if(strnicmp(file,tmp,strlen(tmp))) // and ignore case
+ _abspath(tmp,lib_dir,_MAX_PATH); /* Translate '\\' to '/' */
+ if(strnicmp(file,tmp,strlen(tmp))) /* and ignore case */
       return-1;
   }
 #else /* not __EMX__ */
--- main.c.old Thu Apr 6 22:13:38 2000
+++ main.c Thu Apr 6 22:14:18 2000
@@ -495,15 +495,15 @@
 #ifdef __EMX__
     if(!c)
       switch(getch()){
- case 73: c= 'b'; break; // page up
- case 81: c= ' '; break; // page down
- case 72: c= 'k'; break; // up arrow
- case 75: c= 'h'; break; // left arrow
- case 77: c= 'l'; break; // right arrow
- case 80: c= 'j'; break; // down arrow
- case 15: c=ctrl('u'); break; // shift + tab
- case 71: c= 'g'; break; // home
- case 79: c= 'G'; // end
+ case 73: c= 'b'; break; /* page up */
+ case 81: c= ' '; break; /* page down */
+ case 72: c= 'k'; break; /* up arrow */
+ case 75: c= 'h'; break; /* left arrow */
+ case 77: c= 'l'; break; /* right arrow */
+ case 80: c= 'j'; break; /* down arrow */
+ case 15: c=ctrl('u'); break; /* shift + tab */
+ case 71: c= 'g'; break; /* home */
+ case 79: c= 'G'; /* end */
       }
 #endif /* __EMX__ */
 #ifdef MOUSE
--- rc.c.old Thu Apr 6 22:15:26 2000
+++ rc.c Thu Apr 6 22:15:37 2000
@@ -373,7 +373,7 @@
 static int do_mkdir(const char*dir,long mode){
   char*r,abs[_MAX_PATH];
 
- _abspath(abs,rc_dir,_MAX_PATH); // Translate '\\' to '/'
+ _abspath(abs,rc_dir,_MAX_PATH); /* Translate '\\' to '/' */
   r=strrchr(abs,'/');
   if(r&&r>abs+2)
     *r=0; 

-- 
Christian "naddy" Weisgerber                  naddy@mips.rhein-neckar.de

This archive was generated by hypermail 2b29 : Wed Jul 19 2000 - 10:30:43 CDT