[w3m-dev-en 00091] Re: justification & dragging bugs, colors

From: aito@ei5sun.yz.yamagata-u.ac.jp
Date: Fri Feb 25 2000 - 02:04:10 CST


Hi,

As I have been very busy from the beginning of this month, I've
never hacked w3m code. Now I have a little time, I can begin to
work toword the next release.

In article <20000223074446.A32572@arwen.cs.berkeley.edu>,
        "Adam M. Costello" <w3m-dev-en@mi.med.tohoku.ac.jp> writes:

> I've noticed two bugs: First, when w3m renders HTML, it appears to try
> to fully justify paragraphs by inserting multiple spaces between some
> words, but the right edge still ends up slightly ragged. However, I'd
> prefer no justfication, so that there is always a single space between
> words (except maybe two spaces at the end of a sentence). Perhaps an
> option could be added for that.

If you have the source, you can prohibit the behavior by #undef-ing
FORMAT_NICE in config.h. This option will be deleted in the next release.

> Second, the vertical dragging behaves differently from the horizontal
> dragging. If I drag up and right, the text moves up and left.

I just fixed the bug. I attach the patch below.

> Finally, I'd like to suggest further dividing the color categories.
> Currently, there are five kinds of text:
>
> normal
> link
> image
> form
> active link
>
> I think the image and link categories are too broad. All images are
> colored the same, whether they are links or not. Some people (like me)
> would prefer never to use the same color for links and non-links. Also,
> there is currently no distinction between visited and unvisited links.
> I suggest splitting "link" into two, and splitting "image" into three,
> increasing the number of categories from five to eight:
>
> normal
> unvisited link (non-image)
> visited link (non-image)
> unvisited link image
> visited link image
> non-link image
> form
> active link

As w3m doesn't have memory/file cache, `visited link' doesn't make sense.
link/non-link image will be nice.

                                Akinori Ito

--------------------------------------------------------------------------------
RCS file: /home/aito/cvsroot/w3m/main.c,v
retrieving revision 1.18
diff -u -r1.18 main.c
--- main.c 2000/02/25 06:30:35 1.18
+++ main.c 2000/02/25 07:13:50
@@ -3048,12 +3027,12 @@
 
           if (delta_x > 0) {
             for (i = 0; i < delta_x; i++)
- if(reverse_mouse) col1L();
- else col1R();
- } else if (delta_x < 0) {
- for (i = 0; i < -delta_x; i++)
               if(reverse_mouse) col1R();
               else col1L();
+ } else if (delta_x < 0) {
+ for (i = 0; i < -delta_x; i++)
+ if(reverse_mouse) col1L();
+ else col1R();
           }
         } else {
           if (y == LASTLINE) {



This archive was generated by hypermail 2b29 : Wed Jul 19 2000 - 10:30:43 CDT